Skip to content

gh-146352: In Emscripten pyrepl test, pick port dynamically#146375

Merged
freakboy3742 merged 3 commits intopython:mainfrom
hoodmane:emscripten-pyrepl-test-parallel
Mar 25, 2026
Merged

gh-146352: In Emscripten pyrepl test, pick port dynamically#146375
freakboy3742 merged 3 commits intopython:mainfrom
hoodmane:emscripten-pyrepl-test-parallel

Conversation

@hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Mar 24, 2026 •
edited by bedevere-app bot
Loading

So we don't run into problems when we run multiple copies of the buildbot at once.

@bedevere-app bedevere-app bot mentioned this pull request Mar 24, 2026
Closed
@hoodmane
pythongh-146352: In Emscripten pyrepl test, pick port dynamically
eb54331 
So we don't run into problems when we run multiple copies of the buildbot at
once.
@hoodmane hoodmane requested a review from freakboy3742 March 24, 2026 13:10
@hoodmane hoodmane force-pushed the emscripten-pyrepl-test-parallel branch from 0a4cdbf to eb54331 Compare March 24, 2026 13:10
@hoodmane hoodmane requested a review from vstinner March 24, 2026 13:10
vstinner
vstinner approved these changes Mar 24, 2026
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

freakboy3742
freakboy3742 requested changes Mar 25, 2026
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; two (related) suggestions to address the hard-coding of the cross-build directory, since this PR shows how to get environment vars into the test script.

@bedevere-app
Copy link

bedevere-app bot commented Mar 25, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

freakboy3742
freakboy3742 approved these changes Mar 25, 2026
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM - thanks for the fix!

@freakboy3742 freakboy3742 merged commit 2be147e into python:main Mar 25, 2026
49 of 50 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Mar 25, 2026

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Mar 25, 2026

Sorry, @hoodmane and @freakboy3742, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 2be147e1e75022d66eecb80b46904ed61a7a574f 3.14

@bedevere-app
Copy link

bedevere-app bot commented Mar 25, 2026

GH-146411 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Mar 25, 2026
hoodmane added a commit to hoodmane/cpython that referenced this pull request Mar 25, 2026
@hoodmane
[3.14] pythongh-146352: In Emscripten pyrepl test, pick port dynamica…
7c3a965 
…lly (pythonGH-146375)

Dynamically allocates the port for the pyrepl browser test, so that multiple
tests can run at the same time. Also allows the pyrepl test to honor the
CROSS_BUILD_DIR environment variable.
(cherry picked from commit 2be147e)

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
@vstinner
Copy link
Member

vstinner commented Mar 25, 2026

Thanks for the fix!

vstinner pushed a commit that referenced this pull request Mar 25, 2026
@hoodmane
[3.14] gh-146352: In Emscripten pyrepl test, pick port dynamically (G…
498559a 
…H-146375) (#146411)

Dynamically allocates the port for the pyrepl browser test, so that multiple
tests can run at the same time. Also allows the pyrepl test to honor the
CROSS_BUILD_DIR environment variable.
(cherry picked from commit 2be147e)
@hoodmane hoodmane deleted the emscripten-pyrepl-test-parallel branch March 25, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

@vstinner vstinner vstinner approved these changes

Assignees

@freakboy3742 freakboy3742

Labels

OS-emscripten skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hoodmane @vstinner @freakboy3742